Code suggestions

asashour

Hi all,

There are few points I would like to mention:

• The manual is outdated in https://www.adventurecreator.org/files/Manual.pdf, please add updating this in the release procedure.

• There are some places in the code that could be enhanced:

  1. SceneManager.cameraPerspective_list: make field read-only (suggested by VS)
  2. SceneManager line 244: unnecessary assignment of 'newPlayerStart' (suggested by VS)
  3. AnimeEngine_Legacy.cs: #55 and #57 has duplicate conditions
  4. Should we have != null in many places, or just if(something) is enough?

• Currently, whenever a new version is released (thanks a lot for the frequency), there are few manual changes, how about automating this?

• I will soon need a way to add the "random dialog response" as hinted in https://adventurecreator.org/forum/discussion/486/random-answer, could I implement it an send it to be incorporated to AC code?

• Later, I would also work to integrate Spine, but I am still a beginner at the moment in the whole field.

Thanks a lot.

ChrisIceBox

The manual is outdated

The Manual included in the package is always up-to-date, but I have updated the website one as well.

There are some places in the code that could be enhanced

Thank you, I will consider these changes.

Currently, whenever a new version is released (thanks a lot for the frequency), there are few manual changes, how about automating this?

As in, re-assigning the Managers? The simplest update method is to just not import the /Assets/AdventureCreator/Resources/References.asset file. I've looked into ways to do without this step, but given the way Unity handles asset updates I'm not confident I can do this without causing breakages at this time.

I will soon need a way to add the "random dialog response" as hinted in https://adventurecreator.org/forum/discussion/486/random-answer, could I implement it an send it to be incorporated to AC code?

That's an old thread. You can use either the Variable: Check random number or Variable: Run sequence Actions to run different subsequent Actions.

Later, I would also work to integrate Spine, but I am still a beginner at the moment in the whole field.

A pair of integrations for Spine can be found on the community wiki:

https://adventure-creator.fandom.com/wiki/Spine_and_Adventure_Creator
https://adventure-creator.fandom.com/wiki/Spine_Integration