Potential Bug: Popup switch variables, layout of output nodes drifting

andiliddell

Hi Chris,

Firstly, really loving using the engine, incredible body of work !!

Purely a ongui layout issue i think in the actionlist editor.

I'm using popup switch variables (which are awesome btw) to organise global progress. When I start to use more than 5 or 6 lables, it looks tlike the there's a little drift on the horizontal layout, so eventually, the output dots start to line up with the wrong variable, which is only a minor thing, but really hard to read/hookup, when I'm dealing with lots of them.

I've attached a screen grab (hopefully from google drive).. The top dot should actually be lined up with the top label and theyre all drifitng out as you move down, until the bottom two are fine:
https://drive.google.com/file/d/1vqBOLsv3DoakLZeaZm8hq-tRbkFNtTKY/view?usp=sharing

Hopefully this makes sense. AC version 1.71.3 - Unity version 2019.4.11f1

Thanks again

ChrisIceBox

Thanks for the clear details and screenshot - I'll look into this.

andiliddell

Hi @ChrisIceBox .. I saw in the patch notes that this had been addressed but It still seems to be misaligned, since I upgraded.

Also I've noticed the first node, doesn't autocomplete the drop down now (which might have something to do with it?).

Screen shot 1, is after dragging each node out (notice top one says 'continue' when it should say skip and (7) engine wait): https://drive.google.com/file/d/1x_Fx8uelwcYBSskvHz6qRO-0F96daD-P/view?usp=sharing

Screen shot 2 is after I drag out node one again (to action 7) it then completes the drop down:https://drive.google.com/file/d/1goXXnoiHmmrRlE9V6b_t8fr8-xVwWZ-M/view?usp=sharing

Hope this helps in finding the issue.

ChrisIceBox

Apologies for the continued trouble.

The "Continue" is correct as this defaults to the next Action in the chain (i.e. 7 after 6), but regardless the icons should align.

What platform are you working on?

andiliddell

No need to apologise at all!

I'm continually astounded by the amount of work which has gone into AC, and this is just a little display niggle.

I'm on Windows Unity version 2019.4.11f1 - AC V172.2

Hope this helps. Thanks

ChrisIceBox

It does seem to vary (perhaps by platform, so far unsure) but using the same setup as you doesn't give me the same trouble.

The rendering of such sockets is handled by working out how many pixels they should appear from the bottom of the Action. The separation distance between "Skip" outputs is 44, which is used by ActionListEditorWindow.cs with a couple of instances of:

totalHeight += 44;

Does increasing this to around 46 make things align properly? The wires won't match up, but it'll help to know what the value should be on your end. At the very least, I can store such numbers in a single place for easier tweaking.

andiliddell

Hi Chris,

Sorry for the delay in getting back to you, a busy few weeks!.

46 didn't make much of a difference.. as the image below shows, I bumped it up to 48 and it's pretty much perfect. (apart from the wires as you mentioned )

https://drive.google.com/file/d/1vuVHvVUJTBWAFRMHZWY1qY8X_LJ6RiuO/view?usp=sharing

Hope this helps
Thanks

ChrisIceBox

Thanks. Unfortunately I'm still unsure about the cause of this difference - until I can determine that, I can only move this value to somewhere nicer to edit manually.